Fix resource leak bug in auditbeat/socket#41080
Merged
fearful-symmetry merged 4 commits intoelastic:mainfrom Oct 4, 2024
Merged
Fix resource leak bug in auditbeat/socket#41080fearful-symmetry merged 4 commits intoelastic:mainfrom
fearful-symmetry merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
Contributor
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
nicholasberlin
approved these changes
Oct 2, 2024
haesbaert
approved these changes
Oct 4, 2024
Contributor
haesbaert
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* fix resource leak bug in auditbeat/socket * linter.. * linter... (cherry picked from commit 12e846b)
6 tasks
fearful-symmetry
added a commit
that referenced
this pull request
Oct 14, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This appears to be a long-running resource leak in auditbeat that happens under the following conditions:
forkkretprobe eventpid == tidfor the given exiting process, it will clean up the process hashmap entrypid != tidnever gets cleaned upThis slightly alters the logic so
if pid != tid && s.processExists(tid), we also clean up the entry for the TID on exit.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.